From 0d04bd7fec32f2615caf09b786fea12992c20fe9 Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Sun, 26 Mar 2006 06:03:31 +0000 Subject: [PATCH] Small optimization --- ChangeLog | 5 +++++ ChangeLog.pre-2-10 | 5 +++++ gtk/gtkcellrenderertext.c | 9 +-------- 3 files changed, 11 insertions(+), 8 deletions(-) diff --git a/ChangeLog b/ChangeLog index 697a31da55..e11f546910 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2006-03-26 Matthias Clasen + + * gtk/gtkcellrenderertext.c (gtk_cell_render_text_get_property): + Avoid an unnecessary strdup. (#336013) + 2006-03-24 Matthias Clasen * gtk/gtktextview.c (gtk_text_view_value_changed): Don't call diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10 index 697a31da55..e11f546910 100644 --- a/ChangeLog.pre-2-10 +++ b/ChangeLog.pre-2-10 @@ -1,3 +1,8 @@ +2006-03-26 Matthias Clasen + + * gtk/gtkcellrenderertext.c (gtk_cell_render_text_get_property): + Avoid an unnecessary strdup. (#336013) + 2006-03-24 Matthias Clasen * gtk/gtktextview.c (gtk_text_view_value_changed): Don't call diff --git a/gtk/gtkcellrenderertext.c b/gtk/gtkcellrenderertext.c index 2ff8c52586..a5aca6e192 100644 --- a/gtk/gtkcellrenderertext.c +++ b/gtk/gtkcellrenderertext.c @@ -689,14 +689,7 @@ gtk_cell_renderer_text_get_property (GObject *object, break; case PROP_FONT: - { - /* FIXME GValue imposes a totally gratuitous string copy - * here, we could just hand off string ownership - */ - gchar *str = pango_font_description_to_string (celltext->font); - g_value_set_string (value, str); - g_free (str); - } + g_value_take_string (value, pango_font_description_to_string (celltext->font); break; case PROP_FONT_DESC: -- 2.30.2